Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): should not set the access cache in the data-fn #3299

Merged
merged 1 commit into from
Mar 25, 2021
Merged

fix(runtime-core): should not set the access cache in the data-fn #3299

merged 1 commit into from
Mar 25, 2021

Conversation

HcySunYang
Copy link
Member

Fix: #3297

lidlanca
lidlanca reviewed Feb 25, 2021
View reviewed changes
packages/runtime-core/__tests__/rendererComponent.spec.ts
test('should not set the access cache in the data() function (production mode)', () => {
const Comp = {
data() {
;(this as any).foo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the ; needed here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need, just my habit

@HcySunYang HcySunYang added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Mar 19, 2021
@yyx990803 yyx990803 merged commit 6e88156 into vuejs:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidlanca lidlanca lidlanca left review comments

@edison1105 edison1105 edison1105 approved these changes

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component does not render in prod but does in debug, no errors or warnings
4 participants
@HcySunYang @edison1105 @lidlanca @yyx990803